diff options
| author |   Dave Chinner <dchinner@redhat.com> | 2010-06-24 11:15:47 +1000 |
|---|---|---|
| committer |   Dave Chinner <david@fromorbit.com> | 2010-06-24 11:15:47 +1000 |
| commit | 1920779e67cbf5ea8afef317777c5bf2b8096188 (patch) | |
| tree | f3450e4075162ef5ec360446c301513a5adf316e /fs/xfs/linux-2.6/xfs_export.c | |
| parent | xfs: validate untrusted inode numbers during lookup (diff) | |
| download | linux-dev-1920779e67cbf5ea8afef317777c5bf2b8096188.tar.xz linux-dev-1920779e67cbf5ea8afef317777c5bf2b8096188.zip | |
xfs: rename XFS_IGET_BULKSTAT to XFS_IGET_UNTRUSTED
Inode numbers may come from somewhere external to the filesystem
(e.g. file handles, bulkstat information) and so are inherently
untrusted. Rename the flag we use for these lookups to make it
obvious we are doing a lookup of an untrusted inode number and need
to verify it completely before trying to read it from disk.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to '')
| -rw-r--r-- | fs/xfs/linux-2.6/xfs_export.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/fs/xfs/linux-2.6/xfs_export.c b/fs/xfs/linux-2.6/xfs_export.c index 846b75aeb2ab..92c84a19cc9e 100644 --- a/fs/xfs/linux-2.6/xfs_export.c +++ b/fs/xfs/linux-2.6/xfs_export.c @@ -128,12 +128,11 @@ xfs_nfs_get_inode( return ERR_PTR(-ESTALE); /* - * The XFS_IGET_BULKSTAT means that an invalid inode number is just - * fine and not an indication of a corrupted filesystem. Because - * clients can send any kind of invalid file handle, e.g. after - * a restore on the server we have to deal with this case gracefully. + * The XFS_IGET_UNTRUSTED means that an invalid inode number is just + * fine and not an indication of a corrupted filesystem as clients can + * send invalid file handles and we have to handle it gracefully.. */ - error = xfs_iget(mp, NULL, ino, XFS_IGET_BULKSTAT, + error = xfs_iget(mp, NULL, ino, XFS_IGET_UNTRUSTED, XFS_ILOCK_SHARED, &ip, 0); if (error) { /* |