diff options
| author |   Jaegeuk Kim <jaegeuk@kernel.org> | 2015-04-22 11:03:48 -0700 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2015-05-04 14:15:16 -0700 |
| commit | 7263b1bd0490fca68ee7eedb0b6973cb86d4701c (patch) | |
| tree | 176d95bda119fcee53260373869153c800dde8ef /fs | |
| parent | Revert "f2fs: enhance multi-threads performance" (diff) | |
| download | linux-dev-7263b1bd0490fca68ee7eedb0b6973cb86d4701c.tar.xz linux-dev-7263b1bd0490fca68ee7eedb0b6973cb86d4701c.zip | |
f2fs: fix wrong error hanlder in f2fs_follow_link
The page_follow_link_light returns NULL and its error pointer was remained
in nd->path.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/f2fs/namei.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 7e3794edae42..658e8079aaf9 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -298,16 +298,14 @@ fail: static void *f2fs_follow_link(struct dentry *dentry, struct nameidata *nd) { - struct page *page; + struct page *page = page_follow_link_light(dentry, nd); - page = page_follow_link_light(dentry, nd); - if (IS_ERR(page)) + if (IS_ERR_OR_NULL(page)) return page; /* this is broken symlink case */ if (*nd_get_link(nd) == 0) { - kunmap(page); - page_cache_release(page); + page_put_link(dentry, nd, page); return ERR_PTR(-ENOENT); } return page; |