aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/gpio_keys.h
diff options
context:
space:
mode:
authorMark Rutland <mark.rutland@arm.com>2021-11-26 11:59:23 +0000
committerPeter Zijlstra <peterz@infradead.org>2021-12-13 10:56:09 +0100
commit5fb6e8cf53b005d287d4c2d137a415ff7d025a81 (patch)
tree5f57e4c9180cd6ee01add430b5c844c90457f24d /include/linux/gpio_keys.h
parentMerge tag 'v5.16-rc5' into locking/core, to pick up fixes (diff)
downloadlinux-dev-5fb6e8cf53b005d287d4c2d137a415ff7d025a81.tar.xz
linux-dev-5fb6e8cf53b005d287d4c2d137a415ff7d025a81.zip
locking/atomic: atomic64: Remove unusable atomic ops
The generic atomic64 implementation provides: * atomic64_and_return() * atomic64_or_return() * atomic64_xor_return() ... but none of these exist in the standard atomic64 API as described by scripts/atomic/atomics.tbl, and none of these have prototypes exposed by <asm-generic/atomic64.h>. The lkp kernel test robot noted this results in warnings when building with W=1: lib/atomic64.c:82:5: warning: no previous prototype for 'generic_atomic64_and_return' [-Wmissing-prototypes] lib/atomic64.c:82:5: warning: no previous prototype for 'generic_atomic64_or_return' [-Wmissing-prototypes] lib/atomic64.c:82:5: warning: no previous prototype for 'generic_atomic64_xor_return' [-Wmissing-prototypes] This appears to have been a thinko in commit: 28aa2bda2211f432 ("locking/atomic: Implement atomic{,64,_long}_fetch_{add,sub,and,andnot,or,xor}{,_relaxed,_acquire,_release}()") ... where we grouped add/sub separately from and/ox/xor, so that we could avoid implementing _return forms for the latter group, but forgot to remove ATOMIC64_OP_RETURN() for that group. This doesn't cause any functional problem, but it's pointless to build code which cannot be used. Remove the unusable code. This does not affect add/sub, for which _return forms will still be built. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Boqun Feng <boqun.feng@gmail.com> Link: https://lore.kernel.org/r/20211126115923.41489-1-mark.rutland@arm.com
Diffstat (limited to 'include/linux/gpio_keys.h')
0 files changed, 0 insertions, 0 deletions