diff options
| author |   Chuck Lever <chuck.lever@oracle.com> | 2018-06-18 15:55:43 -0400 |
|---|---|---|
| committer |   Trond Myklebust <trond.myklebust@hammerspace.com> | 2018-06-19 08:53:48 -0400 |
| commit | 0dae72d581dfe795aedaf5523c1faeb18958b1a7 (patch) | |
| tree | 9804943e0565f51482de71ec7e18a766b8c21985 /include/linux/nfs_xdr.h | |
| parent | pNFS: Don't send layoutreturn if the layout is already invalid (diff) | |
| download | linux-dev-0dae72d581dfe795aedaf5523c1faeb18958b1a7.tar.xz linux-dev-0dae72d581dfe795aedaf5523c1faeb18958b1a7.zip | |
sunrpc: Prevent duplicate XID allocation
Krzysztof Kozlowski <krzk@kernel.org> reports that a heavy NFSv4
WRITE workload against a slow NFS server causes his Raspberry Pi
clients to stall. Krzysztof bisected it to commit 37ac86c3a76c
("SUNRPC: Initialize rpc_rqst outside of xprt->reserve_lock") .
I was able to reproduce similar behavior and it appears that rarely
the RPC client layer is re-allocating an XID for an RPC that it has
already partially sent. This results in the client ignoring the
subsequent reply, which carries the original XID.
For various reasons, checking !req->rq_xmit_bytes_sent in
xprt_prepare_transmit is not a 100% reliable mechanism for
determining when a fresh XID is needed.
Trond's preference is to allocate the XID at the time each rpc_rqst
slot is initialized.
This patch should also address a gcc 4.1.2 complaint reported by
Geert Uytterhoeven <geert@linux-m68k.org>.
Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Fixes: 37ac86c3a76c ("SUNRPC: Initialize rpc_rqst outside of ... ")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Diffstat (limited to 'include/linux/nfs_xdr.h')
0 files changed, 0 insertions, 0 deletions