aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/phy.h
diff options
context:
space:
mode:
authorDoug Berger <opendmb@gmail.com>2020-05-18 15:23:59 -0700
committerDavid S. Miller <davem@davemloft.net>2020-05-18 16:54:00 -0700
commita307593a644443db12888f45eed0dafb5869e2cc (patch)
tree4ad32410311fa62c3642c89701243bbf8616c3c6 /include/linux/phy.h
parentrds: convert get_user_pages() --> pin_user_pages() (diff)
downloadlinux-dev-a307593a644443db12888f45eed0dafb5869e2cc.tar.xz
linux-dev-a307593a644443db12888f45eed0dafb5869e2cc.zip
net: phy: simplify phy_link_change arguments
This function was introduced to allow for different handling of link up and link down events particularly with regard to the netif_carrier. The third argument do_carrier allowed the flag to be left unchanged. Since then the phylink has introduced an implementation that completely ignores the third parameter since it never wants to change the flag and the phylib always sets the third parameter to true so the flag is always changed. Therefore the third argument (i.e. do_carrier) is no longer necessary and can be removed. This also means that the phylib phy_link_down() function no longer needs its second argument. Signed-off-by: Doug Berger <opendmb@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/phy.h')
-rw-r--r--include/linux/phy.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 5d8ff5428010..467aa8bf9f64 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -543,7 +543,7 @@ struct phy_device {
u8 mdix;
u8 mdix_ctrl;
- void (*phy_link_change)(struct phy_device *, bool up, bool do_carrier);
+ void (*phy_link_change)(struct phy_device *phydev, bool up);
void (*adjust_link)(struct net_device *dev);
#if IS_ENABLED(CONFIG_MACSEC)