diff options
| author |   David Ahern <dsahern@gmail.com> | 2018-10-07 20:16:23 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-10-08 10:39:03 -0700 |
| commit | 3d0d4337d7a105c5e8ba85c6e7b75437b4c6745e (patch) | |
| tree | 308b38a3ba0246680b43600d771c0a276d2e8049 /include/net/netlink.h | |
| parent | netlink: Pass extack to dump handlers (diff) | |
| download | linux-dev-3d0d4337d7a105c5e8ba85c6e7b75437b4c6745e.tar.xz linux-dev-3d0d4337d7a105c5e8ba85c6e7b75437b4c6745e.zip | |
netlink: Add extack message to nlmsg_parse for invalid header length
Give a user a reason why EINVAL is returned in nlmsg_parse.
Signed-off-by: David Ahern <dsahern@gmail.com>
Acked-by: Christian Brauner <christian@brauner.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | include/net/netlink.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/include/net/netlink.h b/include/net/netlink.h index 589683091f16..9522a0bf1f3a 100644 --- a/include/net/netlink.h +++ b/include/net/netlink.h @@ -516,8 +516,10 @@ static inline int nlmsg_parse(const struct nlmsghdr *nlh, int hdrlen, const struct nla_policy *policy, struct netlink_ext_ack *extack) { - if (nlh->nlmsg_len < nlmsg_msg_size(hdrlen)) + if (nlh->nlmsg_len < nlmsg_msg_size(hdrlen)) { + NL_SET_ERR_MSG(extack, "Invalid header length"); return -EINVAL; + } return nla_parse(tb, maxtype, nlmsg_attrdata(nlh, hdrlen), nlmsg_attrlen(nlh, hdrlen), policy, extack); |