diff options
| author |   Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> | 2017-02-07 11:37:56 -0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-02-07 14:11:04 -0500 |
| commit | 85c727b5948344c8d559e2fda8925e9ddd41c29a (patch) | |
| tree | ca4a55955cedd8871f53b00e859b3d51b9489ace /include/net/sctp/structs.h | |
| parent | bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel_info (diff) | |
| download | linux-dev-85c727b5948344c8d559e2fda8925e9ddd41c29a.tar.xz linux-dev-85c727b5948344c8d559e2fda8925e9ddd41c29a.zip | |
sctp: drop __packed from almost all SCTP structures
__packed is considered harmful as it potentially generates code that
doesn't perform well and its usage should be avoided as much as
possible.
This patch drops __packed from all SCTP structures except one, which is
sctp_signed_cookie. In there it's required, as per changelog on
commit 9834a2bb4970 ("[SCTP]: Fix sctp_cookie alignment in the packet.").
After this patch, no alignment changes neither in x86 or x86_64 and
no exceptions were noticed during testing on both archs.
Code size for SCTP module also didn't change with this patch.
Cc: David Miller <davem@davemloft.net>
Cc: David Laight <David.Laight@ACULAB.COM>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | include/net/sctp/structs.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h index 6a685049f67f..387c802bf248 100644 --- a/include/net/sctp/structs.h +++ b/include/net/sctp/structs.h @@ -374,7 +374,7 @@ typedef struct sctp_sender_hb_info { union sctp_addr daddr; unsigned long sent_at; __u64 hb_nonce; -} __packed sctp_sender_hb_info_t; +} sctp_sender_hb_info_t; struct sctp_stream *sctp_stream_new(__u16 incnt, __u16 outcnt, gfp_t gfp); void sctp_stream_free(struct sctp_stream *stream); |