diff options
| author |   Vlad Buslov <vladbu@mellanox.com> | 2018-09-24 19:22:54 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-09-25 20:17:36 -0700 |
| commit | cfebd7e242d7193a9901222b3e667788810d98c1 (patch) | |
| tree | f7b045d12317526af5a5258266af33b5616387ab /include | |
| parent | net: sched: use Qdisc rcu API instead of relying on rtnl lock (diff) | |
| download | linux-dev-cfebd7e242d7193a9901222b3e667788810d98c1.tar.xz linux-dev-cfebd7e242d7193a9901222b3e667788810d98c1.zip | |
net: sched: change tcf block reference counter type to refcount_t
As a preparation for removing rtnl lock dependency from rules update path,
change tcf block reference counter type to refcount_t to allow modification
by concurrent users.
In block put function perform decrement and check reference counter once to
accommodate concurrent modification by unlocked users. After this change
tcf_chain_put at the end of block put function is called with
block->refcnt==0 and will deallocate block after the last chain is
released, so there is no need to manually deallocate block in this case.
However, if block reference counter reached 0 and there are no chains to
release, block must still be deallocated manually.
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/sch_generic.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h index 43b17f82d8ee..4a86f4d33f07 100644 --- a/include/net/sch_generic.h +++ b/include/net/sch_generic.h @@ -345,7 +345,7 @@ struct tcf_chain { struct tcf_block { struct list_head chain_list; u32 index; /* block index for shared blocks */ - unsigned int refcnt; + refcount_t refcnt; struct net *net; struct Qdisc *q; struct list_head cb_list; |