path: root/init/main.c
diff options
authorMing Lei <tom.leiming@gmail.com>2011-11-17 13:34:31 +0800
committerIngo Molnar <mingo@elte.hu>2011-12-06 08:16:53 +0100
commit73839c5b2eacc15cb0aa79c69b285fc659fa8851 (patch)
tree460e38f3b8036b33a3bed5e4322ea1bb5ef4e3c8 /init/main.c
parentlockdep, kmemcheck: Annotate ->lock in lockdep_init_map() (diff)
init/main.c: Execute lockdep_init() as early as possible
This patch fixes a lockdep warning on ARM platforms: [ 0.000000] WARNING: lockdep init error! Arch code didn't call lockdep_init() early enough? [ 0.000000] Call stack leading to lockdep invocation was: [ 0.000000] [<c00164bc>] save_stack_trace_tsk+0x0/0x90 [ 0.000000] [<ffffffff>] 0xffffffff The warning is caused by printk inside smp_setup_processor_id(). It is safe to do this because lockdep_init() doesn't depend on smp_setup_processor_id(), so improve things that printk can be called as early as possible without lockdep complaint. Signed-off-by: Ming Lei <tom.leiming@gmail.com> Reviewed-by: Yong Zhang <yong.zhang0@gmail.com> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Andrew Morton <akpm@linux-foundation.org> Link: http://lkml.kernel.org/r/1321508072-23853-1-git-send-email-tom.leiming@gmail.com Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to '')
1 files changed, 1 insertions, 2 deletions
diff --git a/init/main.c b/init/main.c
index 217ed23e9487..2c76efb513c2 100644
--- a/init/main.c
+++ b/init/main.c
@@ -469,13 +469,12 @@ asmlinkage void __init start_kernel(void)
char * command_line;
extern const struct kernel_param __start___param[], __stop___param[];
- smp_setup_processor_id();
* Need to run as early as possible, to initialize the
* lockdep hash:
+ smp_setup_processor_id();