diff options
| author |   Yunfeng Ye <yeyunfeng@huawei.com> | 2019-10-23 21:27:34 +0800 |
|---|---|---|
| committer |   Paul Moore <paul@paul-moore.com> | 2019-10-25 11:48:14 -0400 |
| commit | c34c78dfc1fc68a1f5403f996de8ca62f298d7b2 (patch) | |
| tree | 059d13400b64449c3fe3e20dc1bb6223a8db04ef /kernel/audit.c | |
| parent | audit: Report suspicious O_CREAT usage (diff) | |
| download | linux-dev-c34c78dfc1fc68a1f5403f996de8ca62f298d7b2.tar.xz linux-dev-c34c78dfc1fc68a1f5403f996de8ca62f298d7b2.zip | |
audit: remove redundant condition check in kauditd_thread()
Warning is found by the code analysis tool:
"the condition 'if(ac && rc < 0)' is redundant: ac"
The @ac variable has been checked before. It can't be a null pointer
here, so remove the redundant condition check.
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to '')
| -rw-r--r-- | kernel/audit.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/audit.c b/kernel/audit.c index d75485aa25ff..8e09f0f55b4b 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -830,7 +830,7 @@ static int kauditd_thread(void *dummy) rc = kauditd_send_queue(sk, portid, &audit_hold_queue, UNICAST_RETRIES, NULL, kauditd_rehold_skb); - if (ac && rc < 0) { + if (rc < 0) { sk = NULL; auditd_reset(ac); goto main_queue; @@ -840,7 +840,7 @@ static int kauditd_thread(void *dummy) rc = kauditd_send_queue(sk, portid, &audit_retry_queue, UNICAST_RETRIES, NULL, kauditd_hold_skb); - if (ac && rc < 0) { + if (rc < 0) { sk = NULL; auditd_reset(ac); goto main_queue; |