diff options
| author |   Neeraj Upadhyay <neeraju@codeaurora.org> | 2019-03-08 15:16:18 +0530 |
|---|---|---|
| committer |   Paul E. McKenney <paulmck@linux.ibm.com> | 2019-03-26 14:37:49 -0700 |
| commit | 0f58d2ac2c87d27006c2b610668ebc4ff1f7c3ba (patch) | |
| tree | 5e7f2843a29604517e6a0ef6fefad0fecc4a315d /kernel/rcu/tree.c | |
| parent | rcu: Report error for bad rcu_nocbs= parameter values (diff) | |
| download | linux-dev-0f58d2ac2c87d27006c2b610668ebc4ff1f7c3ba.tar.xz linux-dev-0f58d2ac2c87d27006c2b610668ebc4ff1f7c3ba.zip | |
rcu: Fix self-wakeups for grace-period kthread
The current rcu_gp_kthread_wake() function uses in_interrupt()
and thus does a self-wakeup from all interrupt contexts, including
the pointless case where the GP kthread happens to be running with
bottom halves disabled, along with the impossible case where the GP
kthread is running within an NMI handler (you are not supposed to invoke
rcu_gp_kthread_wake() from within an NMI handler. This commit therefore
replaces the in_interrupt() with in_irq(), so that the self-wakeups
happen only from handlers for hardware interrupts and softirqs.
This also makes the code match the comment.
Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to '')
| -rw-r--r-- | kernel/rcu/tree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 5aefd36ac648..139fa1f5c537 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -1585,7 +1585,7 @@ static bool rcu_future_gp_cleanup(struct rcu_node *rnp) static void rcu_gp_kthread_wake(void) { if ((current == rcu_state.gp_kthread && - !in_interrupt() && !in_serving_softirq()) || + !in_irq() && !in_serving_softirq()) || !READ_ONCE(rcu_state.gp_flags) || !rcu_state.gp_kthread) return; |