diff options
| author |   Qais Yousef <qais.yousef@arm.com> | 2019-08-02 11:46:28 +0100 |
|---|---|---|
| committer |   Peter Zijlstra <peterz@infradead.org> | 2019-08-08 09:09:31 +0200 |
| commit | 5c3ceef9ad7b340b0acee6c26d0c9e6429decb2c (patch) | |
| tree | 7e6550de9798a92f0be91e200d6746c379caea8d /kernel/sched/cpufreq_schedutil.c | |
| parent | sched: Rework pick_next_task() slow-path (diff) | |
| download | linux-dev-5c3ceef9ad7b340b0acee6c26d0c9e6429decb2c.tar.xz linux-dev-5c3ceef9ad7b340b0acee6c26d0c9e6429decb2c.zip | |
cpufreq: schedutil: fix equation in comment
scale_irq_capacity() call in schedutil_cpu_util() does
util *= (max - irq)
util /= max
But the comment says
util *= (1 - irq)
util /= max
Fix the comment to match what the scaling function does.
Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>
Link: https://lkml.kernel.org/r/20190802104628.8410-1-qais.yousef@arm.com
Diffstat (limited to '')
| -rw-r--r-- | kernel/sched/cpufreq_schedutil.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index 636ca6f88c8e..e127d89d5974 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -259,9 +259,9 @@ unsigned long schedutil_cpu_util(int cpu, unsigned long util_cfs, * irq metric. Because IRQ/steal time is hidden from the task clock we * need to scale the task numbers: * - * 1 - irq - * U' = irq + ------- * U - * max + * max - irq + * U' = irq + --------- * U + * max */ util = scale_irq_capacity(util, irq, max); util += irq; |