diff options
| author |   Andrey Ryabinin <arbn@yandex-team.com> | 2021-11-15 19:46:04 +0300 |
|---|---|---|
| committer |   Peter Zijlstra <peterz@infradead.org> | 2021-11-23 09:55:22 +0100 |
| commit | 9731698ecb9c851f353ce2496292ff9fcea39dff (patch) | |
| tree | 31a8b27285592b93012f7f955312ebe8c69d5640 /kernel/sched/cputime.c | |
| parent | psi: Fix PSI_MEM_FULL state when tasks are in memstall and doing reclaim (diff) | |
| download | linux-dev-9731698ecb9c851f353ce2496292ff9fcea39dff.tar.xz linux-dev-9731698ecb9c851f353ce2496292ff9fcea39dff.zip | |
cputime, cpuacct: Include guest time in user time in cpuacct.stat
cpuacct.stat in no-root cgroups shows user time without guest time
included int it. This doesn't match with user time shown in root
cpuacct.stat and /proc/<pid>/stat. This also affects cgroup2's cpu.stat
in the same way.
Make account_guest_time() to add user time to cgroup's cpustat to
fix this.
Fixes: ef12fefabf94 ("cpuacct: add per-cgroup utime/stime statistics")
Signed-off-by: Andrey Ryabinin <arbn@yandex-team.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20211115164607.23784-1-arbn@yandex-team.com
Diffstat (limited to '')
| -rw-r--r-- | kernel/sched/cputime.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c index 872e481d5098..042a6dbce8f3 100644 --- a/kernel/sched/cputime.c +++ b/kernel/sched/cputime.c @@ -148,10 +148,10 @@ void account_guest_time(struct task_struct *p, u64 cputime) /* Add guest time to cpustat. */ if (task_nice(p) > 0) { - cpustat[CPUTIME_NICE] += cputime; + task_group_account_field(p, CPUTIME_NICE, cputime); cpustat[CPUTIME_GUEST_NICE] += cputime; } else { - cpustat[CPUTIME_USER] += cputime; + task_group_account_field(p, CPUTIME_USER, cputime); cpustat[CPUTIME_GUEST] += cputime; } } |