diff options
| author |   Hailong Liu <liuhailong@linux.alibaba.com> | 2022-04-01 13:10:11 +0800 |
|---|---|---|
| committer |   Peter Zijlstra <peterz@infradead.org> | 2022-04-22 12:14:06 +0200 |
| commit | 915a087e4c47334a2f7ba2a4092c4bade0873769 (patch) | |
| tree | 8cbb635a259d91071f8d744bc43fe2c704d46cfe /kernel/sched/psi.c | |
| parent | ftrace: Use preemption model accessors for trace header printout (diff) | |
| download | linux-dev-915a087e4c47334a2f7ba2a4092c4bade0873769.tar.xz linux-dev-915a087e4c47334a2f7ba2a4092c4bade0873769.zip | |
psi: Fix trigger being fired unexpectedly at initial
When a trigger being created, its win.start_value and win.start_time are
reset to zero. If group->total[PSI_POLL][t->state] has accumulated before,
this trigger will be fired unexpectedly in the next period, even if its
growth time does not reach its threshold.
So set the window of the new trigger to the current state value.
Signed-off-by: Hailong Liu <liuhailong@linux.alibaba.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Suren Baghdasaryan <surenb@google.com>
Link: https://lore.kernel.org/r/1648789811-3788971-1-git-send-email-liuhailong@linux.alibaba.com
Diffstat (limited to '')
| -rw-r--r-- | kernel/sched/psi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index a4fa3aadfcba..5a49a8c8783e 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -1117,7 +1117,8 @@ struct psi_trigger *psi_trigger_create(struct psi_group *group, t->state = state; t->threshold = threshold_us * NSEC_PER_USEC; t->win.size = window_us * NSEC_PER_USEC; - window_reset(&t->win, 0, 0, 0); + window_reset(&t->win, sched_clock(), + group->total[PSI_POLL][t->state], 0); t->event = 0; t->last_event_time = 0; |