diff options
| author |   Steven Rostedt <srostedt@redhat.com> | 2009-04-29 00:16:21 -0400 |
|---|---|---|
| committer |   Ingo Molnar <mingo@elte.hu> | 2009-04-29 08:02:44 +0200 |
| commit | 7267fa6819467669f5cc2ba81a615dcc88158b4b (patch) | |
| tree | 281e3c2b9765c24364280f02fd9f9aa387c8aa6f /kernel | |
| parent | Linux 2.6.30-rc3 (diff) | |
| download | linux-dev-7267fa6819467669f5cc2ba81a615dcc88158b4b.tar.xz linux-dev-7267fa6819467669f5cc2ba81a615dcc88158b4b.zip | |
tracing: fix ref count in splice pages
The pages allocated for the splice binary buffer did not initialize
the ref count correctly. This caused pages not to be freed and causes
a drastic memory leak.
Thanks to logdev I was able to trace the tracer to find where the leak
was.
[ Impact: stop memory leak when using splice ]
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/trace/trace.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 1ce5dc6372b8..a884c09006c4 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -3448,6 +3448,7 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos, if (!ref) break; + ref->ref = 1; ref->buffer = info->tr->buffer; ref->page = ring_buffer_alloc_read_page(ref->buffer); if (!ref->page) { |