aboutsummaryrefslogtreecommitdiffstats
path: root/lib/kobject.c
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2007-09-20 16:05:12 +0900
committerGreg Kroah-Hartman <gregkh@suse.de>2007-10-12 14:51:11 -0700
commita4e8b912541d5372ae049a3b7c1979968e52c40b (patch)
treea95937748b6216f914abe55ed47c2627e7856bf7 /lib/kobject.c
parentsysfs: implement sysfs_open_dirent (diff)
downloadlinux-dev-a4e8b912541d5372ae049a3b7c1979968e52c40b.tar.xz
linux-dev-a4e8b912541d5372ae049a3b7c1979968e52c40b.zip
sysfs: move sysfs file poll implementation to sysfs_open_dirent
Sysfs file poll implementation is scattered over sysfs and kobject. Event numbering is done in sysfs_dirent but wait itself is done on kobject. This not only unecessarily bloats both kobject and sysfs_dirent but is also buggy - if a sysfs_dirent is removed while there still are pollers, the associaton betwen the kobject and sysfs_dirent breaks and kobject may be freed with the pollers still sleeping on it. This patch moves whole poll implementation into sysfs_open_dirent. Each time a sysfs_open_dirent is created, event number restarts from 1 and pollers sleep on sysfs_open_dirent. As event sequence number is meaningless without any open file and pollers should have open file and thus sysfs_open_dirent, this ephemeral event counting works and is a saner implementation. This patch fixes the dnagling sleepers bug and reduces the sizes of kobject and sysfs_dirent by one pointer. Signed-off-by: Tejun Heo <htejun@gmail.com> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to '')
-rw-r--r--lib/kobject.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/kobject.c b/lib/kobject.c
index e8181d3cec34..fc6db6b4bfc5 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -131,7 +131,6 @@ void kobject_init(struct kobject * kobj)
return;
kref_init(&kobj->kref);
INIT_LIST_HEAD(&kobj->entry);
- init_waitqueue_head(&kobj->poll);
kobj->kset = kset_get(kobj->kset);
}