diff options
| author |   Minchan Kim <minchan@kernel.org> | 2021-04-29 23:01:01 -0700 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2021-04-30 11:20:42 -0700 |
| commit | cef4c7d29d776643e86b600e5ea823f047445d0b (patch) | |
| tree | e46030fddae06c069c0b911d012f7535a254667d /mm/page_alloc.c | |
| parent | mm/page_alloc: drop pr_info_ratelimited() in alloc_contig_range() (diff) | |
| download | linux-dev-cef4c7d29d776643e86b600e5ea823f047445d0b.tar.xz linux-dev-cef4c7d29d776643e86b600e5ea823f047445d0b.zip | |
mm: remove lru_add_drain_all in alloc_contig_range
__alloc_contig_migrate_range already has lru_add_drain_all call via
migrate_prep. It's necessary to move LRU taget pages into LRU list to be
able to isolated. However, lru_add_drain_all call after
__alloc_contig_migrate_range is pointless since it has changed source page
freeing from putback_lru_pages to put_page[1].
This patch removes it.
[1] c6c919eb90e0, ("mm: use put_page() to free page instead of putback_lru_page()"
Link: https://lkml.kernel.org/r/20210303204512.2863087-1-minchan@kernel.org
Signed-off-by: Minchan Kim <minchan@kernel.org>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | mm/page_alloc.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e59d5450d891..c73557bb8c58 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -8649,8 +8649,6 @@ int alloc_contig_range(unsigned long start, unsigned long end, * isolated thus they won't get removed from buddy. */ - lru_add_drain_all(); - order = 0; outer_start = start; while (!PageBuddy(pfn_to_page(outer_start))) { |