diff options
| author |   Nathan Chancellor <natechancellor@gmail.com> | 2019-03-07 09:57:42 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-07 09:52:56 -0800 |
| commit | f9d19a7494e5341a7f256823e32788ae560ca22f (patch) | |
| tree | e465b8ced396d82b924852f251fa98c5db33c3ac /net/atm | |
| parent | ethtool: reduce stack usage with clang (diff) | |
| download | linux-dev-f9d19a7494e5341a7f256823e32788ae560ca22f.tar.xz linux-dev-f9d19a7494e5341a7f256823e32788ae560ca22f.zip | |
net: atm: Use IS_ENABLED in atm_dev_ioctl
When building with -Wsometimes-uninitialized, Clang warns:
net/atm/resources.c:256:6: warning: variable 'number' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
net/atm/resources.c:212:7: warning: variable 'iobuf_len' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
Clang won't realize that compat is 0 when CONFIG_COMPAT is not set until
the constant folding stage, which happens after this semantic analysis.
Use IS_ENABLED instead so that the zero is present at the semantic
analysis stage, which eliminates this warning.
Link: https://github.com/ClangBuiltLinux/linux/issues/386
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/atm')
| -rw-r--r-- | net/atm/resources.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/net/atm/resources.c b/net/atm/resources.c index bada395ecdb1..3e9f6391319e 100644 --- a/net/atm/resources.c +++ b/net/atm/resources.c @@ -203,13 +203,9 @@ int atm_dev_ioctl(unsigned int cmd, void __user *arg, int compat) int __user *sioc_len; int __user *iobuf_len; -#ifndef CONFIG_COMPAT - compat = 0; /* Just so the compiler _knows_ */ -#endif - switch (cmd) { case ATM_GETNAMES: - if (compat) { + if (IS_ENABLED(CONFIG_COMPAT) && compat) { #ifdef CONFIG_COMPAT struct compat_atm_iobuf __user *ciobuf = arg; compat_uptr_t cbuf; @@ -253,7 +249,7 @@ int atm_dev_ioctl(unsigned int cmd, void __user *arg, int compat) break; } - if (compat) { + if (IS_ENABLED(CONFIG_COMPAT) && compat) { #ifdef CONFIG_COMPAT struct compat_atmif_sioc __user *csioc = arg; compat_uptr_t carg; |