diff options
| author |   Xin Long <lucien.xin@gmail.com> | 2017-10-24 13:54:17 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-10-25 10:54:39 +0900 |
| commit | fbb85b3c0112e6aec82863358bdb1b25c7edaec1 (patch) | |
| tree | c84d75a2122c064e81e57da705cd3ab729ceee8d /net/bridge/br_ioctl.c | |
| parent | Merge branch 'bpf-permit-multiple-bpf-attachments-for-a-single-perf-tracepoint-event' (diff) | |
| download | linux-dev-fbb85b3c0112e6aec82863358bdb1b25c7edaec1.tar.xz linux-dev-fbb85b3c0112e6aec82863358bdb1b25c7edaec1.zip | |
bridge: remove rtmsg_ifinfo called in add_del_if
Since commit dc709f375743 ("rtnetlink: bring NETDEV_CHANGEUPPER event
process back in rtnetlink_event"), rtnetlink_event would process the
NETDEV_CHANGEUPPER event and send a notification to userspace.
In add_del_if, it would generate NETDEV_CHANGEUPPER event by whether
netdev_master_upper_dev_link or netdev_upper_dev_unlink. There's
no need to call rtmsg_ifinfo to send the notification any more.
So this patch is to remove it from add_del_if also to avoid redundant
notifications.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/bridge/br_ioctl.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/net/bridge/br_ioctl.c b/net/bridge/br_ioctl.c index 8f29103935a3..16d01a3ff33f 100644 --- a/net/bridge/br_ioctl.c +++ b/net/bridge/br_ioctl.c @@ -102,9 +102,6 @@ static int add_del_if(struct net_bridge *br, int ifindex, int isadd) else ret = br_del_if(br, dev); - if (!ret) - rtmsg_ifinfo(RTM_NEWLINK, dev, IFF_MASTER, GFP_KERNEL); - return ret; } |