diff options
author | KP Singh <kpsingh@kernel.org> | 2022-04-18 15:51:58 +0000 |
---|---|---|
committer | Alexei Starovoitov <ast@kernel.org> | 2022-04-19 17:55:45 -0700 |
commit | dcf456c9a095a6e71f53d6f6f004133ee851ee70 (patch) | |
tree | 9050bc91c5fb6751e8ab4a6076837645ef34dd19 /net/core/bpf_sk_storage.c | |
parent | Merge branch 'Ensure type tags are always ordered first in BTF' (diff) | |
download | linux-dev-dcf456c9a095a6e71f53d6f6f004133ee851ee70.tar.xz linux-dev-dcf456c9a095a6e71f53d6f6f004133ee851ee70.zip |
bpf: Fix usage of trace RCU in local storage.
bpf_{sk,task,inode}_storage_free() do not need to use
call_rcu_tasks_trace as no BPF program should be accessing the owner
as it's being destroyed. The only other reader at this point is
bpf_local_storage_map_free() which uses normal RCU.
The only path that needs trace RCU are:
* bpf_local_storage_{delete,update} helpers
* map_{delete,update}_elem() syscalls
Fixes: 0fe4b381a59e ("bpf: Allow bpf_local_storage to be used by sleepable programs")
Signed-off-by: KP Singh <kpsingh@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20220418155158.2865678-1-kpsingh@kernel.org
Diffstat (limited to '')
-rw-r--r-- | net/core/bpf_sk_storage.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/core/bpf_sk_storage.c b/net/core/bpf_sk_storage.c index e3ac36380520..83d7641ef67b 100644 --- a/net/core/bpf_sk_storage.c +++ b/net/core/bpf_sk_storage.c @@ -40,7 +40,7 @@ static int bpf_sk_storage_del(struct sock *sk, struct bpf_map *map) if (!sdata) return -ENOENT; - bpf_selem_unlink(SELEM(sdata)); + bpf_selem_unlink(SELEM(sdata), true); return 0; } @@ -75,8 +75,8 @@ void bpf_sk_storage_free(struct sock *sk) * sk_storage. */ bpf_selem_unlink_map(selem); - free_sk_storage = bpf_selem_unlink_storage_nolock(sk_storage, - selem, true); + free_sk_storage = bpf_selem_unlink_storage_nolock( + sk_storage, selem, true, false); } raw_spin_unlock_bh(&sk_storage->lock); rcu_read_unlock(); |