diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-08-23 10:46:55 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-08-24 13:46:58 +0100 |
| commit | fa45d484c52c73f79db2c23b0cdfc6c6455093ad (patch) | |
| tree | fa4046a28fd1b138945ad4e81880029d5b22a793 /net/core/dev.c | |
| parent | net: Fix data-races around sysctl_max_skb_frags. (diff) | |
| download | linux-dev-fa45d484c52c73f79db2c23b0cdfc6c6455093ad.tar.xz linux-dev-fa45d484c52c73f79db2c23b0cdfc6c6455093ad.zip | |
net: Fix a data-race around netdev_budget_usecs.
While reading netdev_budget_usecs, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 7acf8a1e8a28 ("Replace 2 jiffies with sysctl netdev_budget_usecs to enable softirq tuning")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/dev.c')
| -rw-r--r-- | net/core/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index c83e23cfc57d..8221322d86db 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -6665,7 +6665,7 @@ static __latent_entropy void net_rx_action(struct softirq_action *h) { struct softnet_data *sd = this_cpu_ptr(&softnet_data); unsigned long time_limit = jiffies + - usecs_to_jiffies(netdev_budget_usecs); + usecs_to_jiffies(READ_ONCE(netdev_budget_usecs)); int budget = READ_ONCE(netdev_budget); LIST_HEAD(list); LIST_HEAD(repoll); |