diff options
| author |   Reshetova, Elena <elena.reshetova@intel.com> | 2017-06-30 13:08:06 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-07-01 07:39:09 -0700 |
| commit | 717d1e993ad8d24a711775d8f2afbcdc76a520a1 (patch) | |
| tree | 09a1b09f27893fcf37f46f04e197fa4621a2345e /net/core/fib_rules.c | |
| parent | net: convert unix_address.refcnt from atomic_t to refcount_t (diff) | |
| download | linux-dev-717d1e993ad8d24a711775d8f2afbcdc76a520a1.tar.xz linux-dev-717d1e993ad8d24a711775d8f2afbcdc76a520a1.zip | |
net: convert fib_rule.refcnt from atomic_t to refcount_t
refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David Windsor <dwindsor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/core/fib_rules.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c index 3bba291c6c32..c4ecd9f75a47 100644 --- a/net/core/fib_rules.c +++ b/net/core/fib_rules.c @@ -46,7 +46,7 @@ int fib_default_rule_add(struct fib_rules_ops *ops, if (r == NULL) return -ENOMEM; - atomic_set(&r->refcnt, 1); + refcount_set(&r->refcnt, 1); r->action = FR_ACT_TO_TBL; r->pref = pref; r->table = table; @@ -283,7 +283,7 @@ jumped: if (err != -EAGAIN) { if ((arg->flags & FIB_LOOKUP_NOREF) || - likely(atomic_inc_not_zero(&rule->refcnt))) { + likely(refcount_inc_not_zero(&rule->refcnt))) { arg->rule = rule; goto out; } |