diff options
| author |   David S. Miller <davem@davemloft.net> | 2012-04-01 20:47:35 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-04-02 04:33:44 -0400 |
| commit | 14ad6647f3c919b4ee987e2058fbc6c10f29bb53 (patch) | |
| tree | 869d184a3b3734874acb03665a122bd125e10ae8 /net/core/gen_stats.c | |
| parent | fib_rules: Stop using NLA_PUT*(). (diff) | |
| download | linux-dev-14ad6647f3c919b4ee987e2058fbc6c10f29bb53.tar.xz linux-dev-14ad6647f3c919b4ee987e2058fbc6c10f29bb53.zip | |
gen_stats: Stop using NLA_PUT*().
These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/gen_stats.c')
| -rw-r--r-- | net/core/gen_stats.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c index 0452eb27a272..ddedf211e588 100644 --- a/net/core/gen_stats.c +++ b/net/core/gen_stats.c @@ -27,7 +27,8 @@ static inline int gnet_stats_copy(struct gnet_dump *d, int type, void *buf, int size) { - NLA_PUT(d->skb, type, size, buf); + if (nla_put(d->skb, type, size, buf)) + goto nla_put_failure; return 0; nla_put_failure: |