diff options
| author |   Eric Sesterhenn <snakebyte@gmx.de> | 2006-09-26 23:26:38 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@sunset.davemloft.net> | 2006-09-28 18:01:23 -0700 |
| commit | 9918f230969bdaf3df012b77abcbcd4cdb0ab221 (patch) | |
| tree | 8cad5227f352a2a0756b2978339eff4b0a5ba0cb /net/core/rtnetlink.c | |
| parent | [SUNRPC]: more sunrpc endianness annotations (diff) | |
| download | linux-dev-9918f230969bdaf3df012b77abcbcd4cdb0ab221.tar.xz linux-dev-9918f230969bdaf3df012b77abcbcd4cdb0ab221.zip | |
[RTNETLINK]: Possible dereference in net/core/rtnetlink.c
another possible dereference spotted by coverity (#cid 1390).
if the nlmsg_parse() call fails, we goto errout, where we call
dev_put(), with dev still initialized to NULL.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/rtnetlink.c')
| -rw-r--r-- | net/core/rtnetlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index d8e25e08cb7e..221e4038216b 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -562,7 +562,7 @@ static int rtnl_getlink(struct sk_buff *skb, struct nlmsghdr* nlh, void *arg) err = nlmsg_parse(nlh, sizeof(*ifm), tb, IFLA_MAX, ifla_policy); if (err < 0) - goto errout; + return err; ifm = nlmsg_data(nlh); if (ifm->ifi_index >= 0) { |