diff options
| author |   Baptiste Lepers <baptiste.lepers@gmail.com> | 2021-01-07 16:11:10 +1100 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2021-01-08 19:15:40 -0800 |
| commit | fd2ddef043592e7de80af53f47fa46fd3573086e (patch) | |
| tree | fbd086182ba7049c4a7b6552809ee757b426a84f /net/core/sock_reuseport.c | |
| parent | net: fix use-after-free when UDP GRO with shared fraglist (diff) | |
| download | linux-dev-fd2ddef043592e7de80af53f47fa46fd3573086e.tar.xz linux-dev-fd2ddef043592e7de80af53f47fa46fd3573086e.zip | |
udp: Prevent reuseport_select_sock from reading uninitialized socks
reuse->socks[] is modified concurrently by reuseport_add_sock. To
prevent reading values that have not been fully initialized, only read
the array up until the last known safe index instead of incorrectly
re-reading the last index of the array.
Fixes: acdcecc61285f ("udp: correct reuseport selection with connected sockets")
Signed-off-by: Baptiste Lepers <baptiste.lepers@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20210107051110.12247-1-baptiste.lepers@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/core/sock_reuseport.c')
| -rw-r--r-- | net/core/sock_reuseport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/sock_reuseport.c b/net/core/sock_reuseport.c index bbdd3c7b6cb5..b065f0a103ed 100644 --- a/net/core/sock_reuseport.c +++ b/net/core/sock_reuseport.c @@ -293,7 +293,7 @@ select_by_hash: i = j = reciprocal_scale(hash, socks); while (reuse->socks[i]->sk_state == TCP_ESTABLISHED) { i++; - if (i >= reuse->num_socks) + if (i >= socks) i = 0; if (i == j) goto out; |