diff options
| author |   YueHaibing <yuehaibing@huawei.com> | 2019-04-01 09:35:54 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-04-01 18:15:10 -0700 |
| commit | 1d3ff0950e2b40dc861b1739029649d03f591820 (patch) | |
| tree | 7f51dc975414b684d55248e63621d135c298a770 /net/dccp | |
| parent | sctp: initialize _pad of sockaddr_in before copying to user memory (diff) | |
| download | linux-dev-1d3ff0950e2b40dc861b1739029649d03f591820.tar.xz linux-dev-1d3ff0950e2b40dc861b1739029649d03f591820.zip | |
dccp: Fix memleak in __feat_register_sp
If dccp_feat_push_change fails, we forget free the mem
which is alloced by kmemdup in dccp_feat_clone_sp_val.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dccp')
| -rw-r--r-- | net/dccp/feat.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/net/dccp/feat.c b/net/dccp/feat.c index f227f002c73d..db87d9f58019 100644 --- a/net/dccp/feat.c +++ b/net/dccp/feat.c @@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local, if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len)) return -ENOMEM; - return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval); + if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) { + kfree(fval.sp.vec); + return -ENOMEM; + } + + return 0; } /** |