diff options
| author |   Arvid Brodin <arvid.brodin@alten.se> | 2014-07-11 18:21:12 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-07-11 15:04:40 -0700 |
| commit | 279f64b7a771d84cbdea51ac2f794becfb06bcd4 (patch) | |
| tree | b065ce42f2a4437813d8fbdc78a67e76866b6ecd /net/hsr/hsr_framereg.c | |
| parent | Merge branch 'r8169_tso_ipv6' (diff) | |
| download | linux-dev-279f64b7a771d84cbdea51ac2f794becfb06bcd4.tar.xz linux-dev-279f64b7a771d84cbdea51ac2f794becfb06bcd4.zip | |
net/hsr: Remove left-over never-true conditional code.
MacAddressB is an array (unsigned char MacAddressB[ETH_ALEN]) and is allocated
as a part of *node_dst (which is a struct hsr_node). So the condition is always
false.
Detected by Dan Carpenter.
Signed-off-by: Arvid Brodin <arvid.brodin@alten.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/hsr/hsr_framereg.c')
| -rw-r--r-- | net/hsr/hsr_framereg.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c index c709c13842cb..bace124d14ef 100644 --- a/net/hsr/hsr_framereg.c +++ b/net/hsr/hsr_framereg.c @@ -290,10 +290,6 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb, } if (port->type != node_dst->AddrB_port) return; - if (!node_dst->MacAddressB) { - WARN_ONCE(1, "%s: No MacAddressB\n", __func__); - return; - } ether_addr_copy(eth_hdr(skb)->h_dest, node_dst->MacAddressB); } |