diff options
| author |   Eric Dumazet <edumazet@google.com> | 2017-06-03 09:29:25 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-06-04 22:56:55 -0400 |
| commit | 77d4b1d36926a9b8387c6b53eeba42bcaaffcea3 (patch) | |
| tree | e2dbe835481d25e7d33cc2afceebc6f03f10173b /net/ipv4/af_inet.c | |
| parent | net: dsa: Fix stale cpu_switch reference after unbind then bind (diff) | |
| download | linux-dev-77d4b1d36926a9b8387c6b53eeba42bcaaffcea3.tar.xz linux-dev-77d4b1d36926a9b8387c6b53eeba42bcaaffcea3.zip | |
net: ping: do not abuse udp_poll()
Alexander reported various KASAN messages triggered in recent kernels
The problem is that ping sockets should not use udp_poll() in the first
place, and recent changes in UDP stack finally exposed this old bug.
Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind")
Fixes: 6d0bfe226116 ("net: ipv6: Add IPv6 support to the ping socket.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Sasha Levin <alexander.levin@verizon.com>
Cc: Solar Designer <solar@openwall.com>
Cc: Vasiliy Kulikov <segoon@openwall.com>
Cc: Lorenzo Colitti <lorenzo@google.com>
Acked-By: Lorenzo Colitti <lorenzo@google.com>
Tested-By: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/af_inet.c')
| -rw-r--r-- | net/ipv4/af_inet.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index f3dad1661343..58925b6597de 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -1043,7 +1043,7 @@ static struct inet_protosw inetsw_array[] = .type = SOCK_DGRAM, .protocol = IPPROTO_ICMP, .prot = &ping_prot, - .ops = &inet_dgram_ops, + .ops = &inet_sockraw_ops, .flags = INET_PROTOSW_REUSE, }, |