diff options
| author |   David Ahern <dsahern@gmail.com> | 2017-08-28 15:14:20 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-08-28 15:17:29 -0700 |
| commit | a8e3bb347d8c32c25830af55466e08979df4e2be (patch) | |
| tree | f9e285520f67cb9a7295a20c4da65798e098bb06 /net/ipv4/af_inet.c | |
| parent | xen-netback: update ubuf_info initialization to anonymous union (diff) | |
| download | linux-dev-a8e3bb347d8c32c25830af55466e08979df4e2be.tar.xz linux-dev-a8e3bb347d8c32c25830af55466e08979df4e2be.zip | |
net: Add comment that early_demux can change via sysctl
Twice patches trying to constify inet{6}_protocol have been reverted:
39294c3df2a8 ("Revert "ipv6: constify inet6_protocol structures"") to
revert 3a3a4e3054137 and then 03157937fe0b5 ("Revert "ipv4: make
net_protocol const"") to revert aa8db499ea67.
Add a comment that the structures can not be const because the
early_demux field can change based on a sysctl.
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/ipv4/af_inet.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index d678820e4306..e31108e5ef79 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -1596,6 +1596,9 @@ static const struct net_protocol igmp_protocol = { }; #endif +/* thinking of making this const? Don't. + * early_demux can change based on sysctl. + */ static struct net_protocol tcp_protocol = { .early_demux = tcp_v4_early_demux, .early_demux_handler = tcp_v4_early_demux, @@ -1606,6 +1609,9 @@ static struct net_protocol tcp_protocol = { .icmp_strict_tag_validation = 1, }; +/* thinking of making this const? Don't. + * early_demux can change based on sysctl. + */ static struct net_protocol udp_protocol = { .early_demux = udp_v4_early_demux, .early_demux_handler = udp_v4_early_demux, |