diff options
| author |   Eric Dumazet <edumazet@google.com> | 2013-11-14 13:37:54 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-11-14 17:31:14 -0500 |
| commit | c9e9042994d37cbc1ee538c500e9da1bb9d1bcdf (patch) | |
| tree | 6f4f8ea5fd922fa8fa3cfa87b17d2abcadab02d3 /net/ipv4/datagram.c | |
| parent | net/hsr: Fix possible leak in 'hsr_get_node_status()' (diff) | |
| download | linux-dev-c9e9042994d37cbc1ee538c500e9da1bb9d1bcdf.tar.xz linux-dev-c9e9042994d37cbc1ee538c500e9da1bb9d1bcdf.zip | |
ipv4: fix possible seqlock deadlock
ip4_datagram_connect() being called from process context,
it should use IP_INC_STATS() instead of IP_INC_STATS_BH()
otherwise we can deadlock on 32bit arches, or get corruptions of
SNMP counters.
Fixes: 584bdf8cbdf6 ("[IPV4]: Fix "ipOutNoRoutes" counter error for TCP and UDP")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/datagram.c')
| -rw-r--r-- | net/ipv4/datagram.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/datagram.c b/net/ipv4/datagram.c index b28e863fe0a7..19e36376d2a0 100644 --- a/net/ipv4/datagram.c +++ b/net/ipv4/datagram.c @@ -57,7 +57,7 @@ int ip4_datagram_connect(struct sock *sk, struct sockaddr *uaddr, int addr_len) if (IS_ERR(rt)) { err = PTR_ERR(rt); if (err == -ENETUNREACH) - IP_INC_STATS_BH(sock_net(sk), IPSTATS_MIB_OUTNOROUTES); + IP_INC_STATS(sock_net(sk), IPSTATS_MIB_OUTNOROUTES); goto out; } |