aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv4/ip_input.c
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2018-07-31 15:27:56 -0700
committerDavid S. Miller <davem@davemloft.net>2018-09-10 10:06:54 -0700
commit992cba7e276d438ac8b0a8c17b147b37c8c286f7 (patch)
tree50aaa7b0231a83b7b58ad60c4da88d9905b89b0e /net/ipv4/ip_input.c
parentnet: Add and use skb_mark_not_on_list(). (diff)
downloadlinux-dev-992cba7e276d438ac8b0a8c17b147b37c8c286f7.tar.xz
linux-dev-992cba7e276d438ac8b0a8c17b147b37c8c286f7.zip
net: Add and use skb_list_del_init().
It documents what is happening, and eliminates the spurious list pointer poisoning. In the long term, in order to get proper list head debugging, we might want to use the list poison value as the indicator that an SKB is a singleton and not on a list. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_input.c')
-rw-r--r--net/ipv4/ip_input.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c
index eba7f3883230..35a786c0aaa0 100644
--- a/net/ipv4/ip_input.c
+++ b/net/ipv4/ip_input.c
@@ -531,11 +531,7 @@ static void ip_sublist_rcv_finish(struct list_head *head)
struct sk_buff *skb, *next;
list_for_each_entry_safe(skb, next, head, list) {
- list_del(&skb->list);
- /* Handle ip{6}_forward case, as sch_direct_xmit have
- * another kind of SKB-list usage (see validate_xmit_skb_list)
- */
- skb_mark_not_on_list(skb);
+ skb_list_del_init(skb);
dst_input(skb);
}
}