diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-06 16:39:58 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-08 12:10:33 +0100 |
| commit | 47e6ab24e8c6e3ca10ceb5835413f401f90de4bf (patch) | |
| tree | a8f6ca02dfc283f9c173d5c34077e2c70a42903f /net/ipv4/tcp.c | |
| parent | sysctl: Fix data races in proc_dointvec_jiffies(). (diff) | |
| download | linux-dev-47e6ab24e8c6e3ca10ceb5835413f401f90de4bf.tar.xz linux-dev-47e6ab24e8c6e3ca10ceb5835413f401f90de4bf.zip | |
tcp: Fix a data-race around sysctl_tcp_max_orphans.
While reading sysctl_tcp_max_orphans, it can be changed concurrently.
So, we need to add READ_ONCE() to avoid a data-race.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/ipv4/tcp.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 028513d3e2a2..2222dfdde316 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -2715,7 +2715,8 @@ static void tcp_orphan_update(struct timer_list *unused) static bool tcp_too_many_orphans(int shift) { - return READ_ONCE(tcp_orphan_cache) << shift > sysctl_tcp_max_orphans; + return READ_ONCE(tcp_orphan_cache) << shift > + READ_ONCE(sysctl_tcp_max_orphans); } bool tcp_check_oom(struct sock *sk, int shift) |