diff options
| author |   Eric Dumazet <edumazet@google.com> | 2019-10-09 15:32:35 -0700 |
|---|---|---|
| committer |   Jakub Kicinski <jakub.kicinski@netronome.com> | 2019-10-09 21:43:00 -0700 |
| commit | eac66402d1c342f07ff38f8d631ff95eb7ad3220 (patch) | |
| tree | d25d4b62d8f9a01ed18b820307bfb0080a26a28f /net/ipv4/tcp.c | |
| parent | net: silence KCSAN warnings around sk_add_backlog() calls (diff) | |
| download | linux-dev-eac66402d1c342f07ff38f8d631ff95eb7ad3220.tar.xz linux-dev-eac66402d1c342f07ff38f8d631ff95eb7ad3220.zip | |
net: annotate sk->sk_rcvlowat lockless reads
sock_rcvlowat() or int_sk_rcvlowat() might be called without the socket
lock for example from tcp_poll().
Use READ_ONCE() to document the fact that other cpus might change
sk->sk_rcvlowat under us and avoid KCSAN splats.
Use WRITE_ONCE() on write sides too.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Diffstat (limited to '')
| -rw-r--r-- | net/ipv4/tcp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 888c92b63f5a..8781a92ea4b6 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -1699,7 +1699,7 @@ int tcp_set_rcvlowat(struct sock *sk, int val) else cap = sock_net(sk)->ipv4.sysctl_tcp_rmem[2] >> 1; val = min(val, cap); - sk->sk_rcvlowat = val ? : 1; + WRITE_ONCE(sk->sk_rcvlowat, val ? : 1); /* Check if we need to signal EPOLLIN right now */ tcp_data_ready(sk); |