aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv4/tcp_bic.c
diff options
context:
space:
mode:
authorStephen Hemminger <shemminger@osdl.org>2005-11-01 15:26:45 -0800
committerArnaldo Carvalho de Melo <acme@mandriva.com>2005-11-02 21:24:01 -0200
commit450b5b18983cc15f4d27bd3f62901e02281e818b (patch)
treedea7c8dbd045cde1d4fc46b63ff9c5d66f39f536 /net/ipv4/tcp_bic.c
parent[MCAST]: ip[6]_mc_add_src should be called when number of sources is zero (diff)
downloadlinux-dev-450b5b18983cc15f4d27bd3f62901e02281e818b.tar.xz
linux-dev-450b5b18983cc15f4d27bd3f62901e02281e818b.zip
[TCP]: BIC max increment too large
The max growth of BIC TCP is too large. Original code was based on BIC 1.0 and the default there was 32. Later code (2.6.13) included compensation for delayed acks, and should have reduced the default value to 16; since normally TCP gets one ack for every two packets sent. The current value of 32 makes BIC too aggressive and unfair to other flows. Submitted-by: Injong Rhee <rhee@eos.ncsu.edu> Signed-off-by: Stephen Hemminger <shemminger@osdl.org> Acked-by: Ian McDonald <imcdnzl@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Diffstat (limited to 'net/ipv4/tcp_bic.c')
-rw-r--r--net/ipv4/tcp_bic.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_bic.c b/net/ipv4/tcp_bic.c
index 6d80e063c187..ae35e0609047 100644
--- a/net/ipv4/tcp_bic.c
+++ b/net/ipv4/tcp_bic.c
@@ -27,7 +27,7 @@
*/
static int fast_convergence = 1;
-static int max_increment = 32;
+static int max_increment = 16;
static int low_window = 14;
static int beta = 819; /* = 819/1024 (BICTCP_BETA_SCALE) */
static int low_utilization_threshold = 153;