diff options
| author |   Haiyang Zhang <haiyangz@microsoft.com> | 2020-02-21 08:32:18 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-02-23 16:32:37 -0800 |
| commit | f6f13c125e05603f68f5bf31f045b95e6d493598 (patch) | |
| tree | 3a9bb0f93b7bfa15f5be922144d0bb48968ea475 /net/ipv4/tcp_input.c | |
| parent | net: usb: qmi_wwan: restore mtu min/max values after raw_ip switch (diff) | |
| download | linux-dev-f6f13c125e05603f68f5bf31f045b95e6d493598.tar.xz linux-dev-f6f13c125e05603f68f5bf31f045b95e6d493598.zip | |
hv_netvsc: Fix unwanted wakeup in netvsc_attach()
When netvsc_attach() is called by operations like changing MTU, etc.,
an extra wakeup may happen while netvsc_attach() calling
rndis_filter_device_add() which sends rndis messages when queue is
stopped in netvsc_detach(). The completion message will wake up queue 0.
We can reproduce the issue by changing MTU etc., then the wake_queue
counter from "ethtool -S" will increase beyond stop_queue counter:
stop_queue: 0
wake_queue: 1
The issue causes queue wake up, and counter increment, no other ill
effects in current code. So we didn't see any network problem for now.
To fix this, initialize tx_disable to true, and set it to false when
the NIC is ready to be attached or registered.
Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions