aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv4/tcp_ulp.c
diff options
context:
space:
mode:
authorSabrina Dubroca <sd@queasysnail.net>2017-08-14 18:04:24 +0200
committerDavid S. Miller <davem@davemloft.net>2017-08-14 22:17:05 -0700
commit539a06baedd06127389b254f6b9f016ca072da13 (patch)
tree0ad4648c157cf03a6f00c4a55c159a1a766eb972 /net/ipv4/tcp_ulp.c
parentMerge branch 'Add-new-PCI_DEV_FLAGS_NO_RELAXED_ORDERING-flag' (diff)
downloadlinux-dev-539a06baedd06127389b254f6b9f016ca072da13.tar.xz
linux-dev-539a06baedd06127389b254f6b9f016ca072da13.zip
tcp: ulp: avoid module refcnt leak in tcp_set_ulp
__tcp_ulp_find_autoload returns tcp_ulp_ops after taking a reference on the module. Then, if ->init fails, tcp_set_ulp propagates the error but nothing releases that reference. Fixes: 734942cc4ea6 ("tcp: ULP infrastructure") Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_ulp.c')
-rw-r--r--net/ipv4/tcp_ulp.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/net/ipv4/tcp_ulp.c b/net/ipv4/tcp_ulp.c
index 2417f55374c5..6bb9e14c710a 100644
--- a/net/ipv4/tcp_ulp.c
+++ b/net/ipv4/tcp_ulp.c
@@ -122,14 +122,14 @@ int tcp_set_ulp(struct sock *sk, const char *name)
ulp_ops = __tcp_ulp_find_autoload(name);
if (!ulp_ops)
- err = -ENOENT;
- else
- err = ulp_ops->init(sk);
+ return -ENOENT;
- if (err)
- goto out;
+ err = ulp_ops->init(sk);
+ if (err) {
+ module_put(ulp_ops->owner);
+ return err;
+ }
icsk->icsk_ulp_ops = ulp_ops;
- out:
- return err;
+ return 0;
}