diff options
| author |   Hayes Wang <hayeswang@realtek.com> | 2019-11-22 16:21:09 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-11-22 10:07:44 -0800 |
| commit | 5b1d9c17a3e0c16e1c9adf9c8a89f2735cb6dff8 (patch) | |
| tree | e3e2eb7b94cf7be4ec0886ca20fe4b125e2ed991 /net/ipv4 | |
| parent | Merge tag 'linux-can-fixes-for-5.4-20191122' of git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can (diff) | |
| download | linux-dev-5b1d9c17a3e0c16e1c9adf9c8a89f2735cb6dff8.tar.xz linux-dev-5b1d9c17a3e0c16e1c9adf9c8a89f2735cb6dff8.zip | |
r8152: avoid to call napi_disable twice
Call napi_disable() twice would cause dead lock. There are three situations
may result in the issue.
1. rtl8152_pre_reset() and set_carrier() are run at the same time.
2. Call rtl8152_set_tunable() after rtl8152_close().
3. Call rtl8152_set_ringparam() after rtl8152_close().
For #1, use the same solution as commit 84811412464d ("r8152: Re-order
napi_disable in rtl8152_close"). For #2 and #3, add checking the flag
of IFF_UP and using napi_disable/napi_enable during mutex.
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
0 files changed, 0 insertions, 0 deletions