diff options
| author |   Maciej Żenczykowski <maze@google.com> | 2021-11-23 14:32:08 -0800 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2021-11-24 18:57:23 -0800 |
| commit | 305e95bb893cc50f7c59edf2b47d95effe73498a (patch) | |
| tree | dd1aa95f01be64d5f1045cf6c8573e083f1277d8 /net/ipv6/ipv6_sockglue.c | |
| parent | net-ipv6: do not allow IPV6_TCLASS to muck with tcp's ECN (diff) | |
| download | linux-dev-305e95bb893cc50f7c59edf2b47d95effe73498a.tar.xz linux-dev-305e95bb893cc50f7c59edf2b47d95effe73498a.zip | |
net-ipv6: changes to ->tclass (via IPV6_TCLASS) should sk_dst_reset()
This is to match ipv4 behaviour, see __ip_sock_set_tos()
implementation.
Technically for ipv6 this might not be required because normally we
do not allow tclass to influence routing, yet the cli tooling does
support it:
lpk11:~# ip -6 rule add pref 5 tos 45 lookup 5
lpk11:~# ip -6 rule
5: from all tos 0x45 lookup 5
and in general dscp/tclass based routing does make sense.
We already have cases where dscp can affect vlan priority and/or
transmit queue (especially on wifi).
So let's just make things match. Easier to reason about and no harm.
Cc: Eric Dumazet <edumazet@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Link: https://lore.kernel.org/r/20211123223208.1117871-1-zenczykowski@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | net/ipv6/ipv6_sockglue.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index 8970b1a45257..a733803a710c 100644 --- a/net/ipv6/ipv6_sockglue.c +++ b/net/ipv6/ipv6_sockglue.c @@ -603,7 +603,10 @@ static int do_ipv6_setsockopt(struct sock *sk, int level, int optname, val &= ~INET_ECN_MASK; val |= np->tclass & INET_ECN_MASK; } - np->tclass = val; + if (np->tclass != val) { + np->tclass = val; + sk_dst_reset(sk); + } retv = 0; break; |