diff options
| author |   Tom Parkin <tparkin@katalix.com> | 2020-07-24 16:31:50 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-07-24 17:19:14 -0700 |
| commit | 7a379558c28c435681221aa5d84ead8ff19211be (patch) | |
| tree | 0466a1b2aaaa57fc90349f501df60f827ce4fdf1 /net/l2tp/l2tp_debugfs.c | |
| parent | l2tp: avoid multiple assignments (diff) | |
| download | linux-dev-7a379558c28c435681221aa5d84ead8ff19211be.tar.xz linux-dev-7a379558c28c435681221aa5d84ead8ff19211be.zip | |
l2tp: WARN_ON rather than BUG_ON in l2tp_dfs_seq_start
l2tp_dfs_seq_start had a BUG_ON to catch a possible programming error in
l2tp_dfs_seq_open.
Since we can easily bail out of l2tp_dfs_seq_start, prefer to do that
and flag the error with a WARN_ON rather than crashing the kernel.
Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/l2tp/l2tp_debugfs.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c index 72ba83aa0eaf..96cb9601c21b 100644 --- a/net/l2tp/l2tp_debugfs.c +++ b/net/l2tp/l2tp_debugfs.c @@ -72,7 +72,10 @@ static void *l2tp_dfs_seq_start(struct seq_file *m, loff_t *offs) if (!pos) goto out; - BUG_ON(!m->private); + if (WARN_ON(!m->private)) { + pd = NULL; + goto out; + } pd = m->private; if (!pd->tunnel) |