diff options
| author |   Tom Parkin <tparkin@katalix.com> | 2020-08-22 15:59:03 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-08-22 12:44:37 -0700 |
| commit | 5ee759cda51b9b1c28994ea36e314427a58cb6d7 (patch) | |
| tree | b30c1fba1b05e607e68473d7b11b7f65fd44142b /net/l2tp/l2tp_ppp.c | |
| parent | l2tp: remove noisy logging, use appropriate log levels (diff) | |
| download | linux-dev-5ee759cda51b9b1c28994ea36e314427a58cb6d7.tar.xz linux-dev-5ee759cda51b9b1c28994ea36e314427a58cb6d7.zip | |
l2tp: use standard API for warning log messages
The l2tp_* log wrappers only emit messages of a given category if the
tunnel or session structure has the appropriate flag set in its debug
field. Flags default to being unset.
For warning messages, this doesn't make a lot of sense since an
administrator is likely to want to know about datapath warnings without
needing to tweak the debug flags setting for a given tunnel or session
instance.
Modify l2tp_warn callsites to use pr_warn_ratelimited instead for
unconditional output of warning messages.
Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/l2tp/l2tp_ppp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c index 660ea95e0910..bd6bb17dfadb 100644 --- a/net/l2tp/l2tp_ppp.c +++ b/net/l2tp/l2tp_ppp.c @@ -251,7 +251,7 @@ static void pppol2tp_recv(struct l2tp_session *session, struct sk_buff *skb, int no_sock: rcu_read_unlock(); - l2tp_warn(session, L2TP_MSG_DATA, "%s: no socket\n", session->name); + pr_warn_ratelimited("%s: no socket in recv\n", session->name); kfree_skb(skb); } |