path: root/net/packet
diff options
authorZhiqiang Liu <liuzhiqiang26@huawei.com>2019-03-16 17:02:54 +0800
committerDavid S. Miller <davem@davemloft.net>2019-03-18 17:07:27 -0700
commitcc4807bb609230d8959fd732b0bf3bd4c2de8eac (patch)
tree97cbca43b015f1d37d89c5a2a4ffeccdaa75e19a /net/packet
parentnet: aquantia: fix rx checksum offload for UDP/TCP over IPv6 (diff)
vxlan: Don't call gro_cells_destroy() before device is unregistered
Commit ad6c9986bcb62 ("vxlan: Fix GRO cells race condition between receive and link delete") fixed a race condition for the typical case a vxlan device is dismantled from the current netns. But if a netns is dismantled, vxlan_destroy_tunnels() is called to schedule a unregister_netdevice_queue() of all the vxlan tunnels that are related to this netns. In vxlan_destroy_tunnels(), gro_cells_destroy() is called and finished before unregister_netdevice_queue(). This means that the gro_cells_destroy() call is done too soon, for the same reasons explained in above commit. So we need to fully respect the RCU rules, and thus must remove the gro_cells_destroy() call or risk use after-free. Fixes: 58ce31cca1ff ("vxlan: GRO support at tunnel layer") Signed-off-by: Suanming.Mou <mousuanming@huawei.com> Suggested-by: Eric Dumazet <eric.dumazet@gmail.com> Reviewed-by: Stefano Brivio <sbrivio@redhat.com> Reviewed-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/packet')
0 files changed, 0 insertions, 0 deletions