diff options
| author |   David Howells <dhowells@redhat.com> | 2020-03-12 21:40:06 +0000 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2020-03-13 23:04:35 +0000 |
| commit | 7d7587db0d7fd1138f2afcffdc46a8e15630b944 (patch) | |
| tree | 55437aafa9ea8a969e7271ce724e50aae0ddeae9 /net/rxrpc/ar-internal.h | |
| parent | afs: Fix handling of an abort from a service handler (diff) | |
| download | linux-dev-7d7587db0d7fd1138f2afcffdc46a8e15630b944.tar.xz linux-dev-7d7587db0d7fd1138f2afcffdc46a8e15630b944.zip | |
afs: Fix client call Rx-phase signal handling
Fix the handling of signals in client rxrpc calls made by the afs
filesystem. Ignore signals completely, leaving call abandonment or
connection loss to be detected by timeouts inside AF_RXRPC.
Allowing a filesystem call to be interrupted after the entire request has
been transmitted and an abort sent means that the server may or may not
have done the action - and we don't know. It may even be worse than that
for older servers.
Fixes: bc5e3a546d55 ("rxrpc: Use MSG_WAITALL to tell sendmsg() to temporarily ignore signals")
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | net/rxrpc/ar-internal.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h index 1f72f43b082d..3eb1ab40ca5c 100644 --- a/net/rxrpc/ar-internal.h +++ b/net/rxrpc/ar-internal.h @@ -675,7 +675,6 @@ struct rxrpc_call { /* transmission-phase ACK management */ ktime_t acks_latest_ts; /* Timestamp of latest ACK received */ - rxrpc_serial_t acks_latest; /* serial number of latest ACK received */ rxrpc_seq_t acks_lowest_nak; /* Lowest NACK in the buffer (or ==tx_hard_ack) */ rxrpc_seq_t acks_lost_top; /* tx_top at the time lost-ack ping sent */ rxrpc_serial_t acks_lost_ping; /* Serial number of probe ACK */ |