diff options
| author |   David Howells <dhowells@redhat.com> | 2020-09-14 13:10:00 +0100 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2020-09-14 16:18:59 +0100 |
| commit | 8806245a3e7ad6aafc5bd8c58b0f0dea82a8e4c5 (patch) | |
| tree | 8092474ded42ed3f19856b76a2c94cad1679cdcf /net/rxrpc/ar-internal.h | |
| parent | rxrpc: Fix a missing NULL-pointer check in a trace (diff) | |
| download | linux-dev-8806245a3e7ad6aafc5bd8c58b0f0dea82a8e4c5.tar.xz linux-dev-8806245a3e7ad6aafc5bd8c58b0f0dea82a8e4c5.zip | |
rxrpc: Fix rxrpc_bundle::alloc_error to be signed
The alloc_error field in the rxrpc_bundle struct should be signed as it has
negative error codes assigned to it. Checks directly on it may then fail,
and may produce a warning like this:
net/rxrpc/conn_client.c:662 rxrpc_wait_for_channel()
warn: 'bundle->alloc_error' is unsigned
Fixes: 245500d853e9 ("rxrpc: Rewrite the client connection manager")
Reported-by Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | net/rxrpc/ar-internal.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h index cd5a80b34738..19f714386654 100644 --- a/net/rxrpc/ar-internal.h +++ b/net/rxrpc/ar-internal.h @@ -395,7 +395,7 @@ struct rxrpc_bundle { unsigned int debug_id; bool try_upgrade; /* True if the bundle is attempting upgrade */ bool alloc_conn; /* True if someone's getting a conn */ - unsigned short alloc_error; /* Error from last conn allocation */ + short alloc_error; /* Error from last conn allocation */ spinlock_t channel_lock; struct rb_node local_node; /* Node in local->client_conns */ struct list_head waiting_calls; /* Calls waiting for channels */ |