path: root/net/rxrpc/output.c
diff options
authorDavid Howells <dhowells@redhat.com>2019-07-02 15:55:28 +0100
committerDavid S. Miller <davem@davemloft.net>2019-07-02 12:09:09 -0700
commit3427beb6375d04e9627c67343872e79341a684ea (patch)
tree5b888c946a652af7f2100013bc33fa90cf20eac5 /net/rxrpc/output.c
parentnfc: st-nci: remove redundant assignment to variable r (diff)
rxrpc: Fix uninitialized error code in rxrpc_send_data_packet()
With gcc 4.1: net/rxrpc/output.c: In function ‘rxrpc_send_data_packet’: net/rxrpc/output.c:338: warning: ‘ret’ may be used uninitialized in this function Indeed, if the first jump to the send_fragmentable label is made, and the address family is not handled in the switch() statement, ret will be used uninitialized. Fix this by BUG()'ing as is done in other places in rxrpc where internal support for future address families will need adding. It should not be possible to reach this normally as the address families are checked up-front. Fixes: 5a924b8951f835b5 ("rxrpc: Don't store the rxrpc header in the Tx queue sk_buffs") Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: David Howells <dhowells@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
1 files changed, 3 insertions, 0 deletions
diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c
index a0b6abfbd277..948e3fe249ec 100644
--- a/net/rxrpc/output.c
+++ b/net/rxrpc/output.c
@@ -519,6 +519,9 @@ send_fragmentable:
+ default:
+ BUG();
if (ret < 0)