diff options
| author |   David Howells <dhowells@redhat.com> | 2016-10-06 08:11:49 +0100 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2016-10-06 08:11:49 +0100 |
| commit | a5af7e1fc69a46f29b977fd4b570e0ac414c2338 (patch) | |
| tree | d3ecc4df97f90a40d3f3aa6827bfe4201eba71e7 /net/rxrpc/sendmsg.c | |
| parent | rxrpc: Fix warning by splitting rxrpc_send_call_packet() (diff) | |
| download | linux-dev-a5af7e1fc69a46f29b977fd4b570e0ac414c2338.tar.xz linux-dev-a5af7e1fc69a46f29b977fd4b570e0ac414c2338.zip | |
rxrpc: Fix loss of PING RESPONSE ACK production due to PING ACKs
Separate the output of PING ACKs from the output of other sorts of ACK so
that if we receive a PING ACK and schedule transmission of a PING RESPONSE
ACK, the response doesn't get cancelled by a PING ACK we happen to be
scheduling transmission of at the same time.
If a PING RESPONSE gets lost, the other side might just sit there waiting
for it and refuse to proceed otherwise.
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | net/rxrpc/sendmsg.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c index 901b28ceeff4..55a2fb2cfc2f 100644 --- a/net/rxrpc/sendmsg.c +++ b/net/rxrpc/sendmsg.c @@ -197,7 +197,7 @@ static int rxrpc_send_data(struct rxrpc_sock *rx, do { /* Check to see if there's a ping ACK to reply to. */ if (call->ackr_reason == RXRPC_ACK_PING_RESPONSE) - rxrpc_send_ack_packet(call); + rxrpc_send_ack_packet(call, false); if (!skb) { size_t size, chunk, max, space; |