diff options
| author |   Cong Wang <xiyou.wangcong@gmail.com> | 2018-08-19 12:22:06 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-08-21 12:45:44 -0700 |
| commit | 97a3f84f2c84f81b859aedd2c186df09c2ee21a6 (patch) | |
| tree | 94b69a5b9f938534b7ae0733cea74712c3f15472 /net/sched/act_csum.c | |
| parent | net_sched: improve and refactor tcf_action_put_many() (diff) | |
| download | linux-dev-97a3f84f2c84f81b859aedd2c186df09c2ee21a6.tar.xz linux-dev-97a3f84f2c84f81b859aedd2c186df09c2ee21a6.zip | |
net_sched: remove unnecessary ops->delete()
All ops->delete() wants is getting the tn->idrinfo, but we already
have tc_action before calling ops->delete(), and tc_action has
a pointer ->idrinfo.
More importantly, each type of action does the same thing, that is,
just calling tcf_idr_delete_index().
So it can be just removed.
Fixes: b409074e6693 ("net: sched: add 'delete' function to action ops")
Cc: Jiri Pirko <jiri@mellanox.com>
Cc: Vlad Buslov <vladbu@mellanox.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_csum.c')
| -rw-r--r-- | net/sched/act_csum.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/net/sched/act_csum.c b/net/sched/act_csum.c index e698d3fe2080..b8a67ae3105a 100644 --- a/net/sched/act_csum.c +++ b/net/sched/act_csum.c @@ -659,13 +659,6 @@ static size_t tcf_csum_get_fill_size(const struct tc_action *act) return nla_total_size(sizeof(struct tc_csum)); } -static int tcf_csum_delete(struct net *net, u32 index) -{ - struct tc_action_net *tn = net_generic(net, csum_net_id); - - return tcf_idr_delete_index(tn, index); -} - static struct tc_action_ops act_csum_ops = { .kind = "csum", .type = TCA_ACT_CSUM, @@ -677,7 +670,6 @@ static struct tc_action_ops act_csum_ops = { .walk = tcf_csum_walker, .lookup = tcf_csum_search, .get_fill_size = tcf_csum_get_fill_size, - .delete = tcf_csum_delete, .size = sizeof(struct tcf_csum), }; |