path: root/net/sched/act_sample.c
diff options
authorCong Wang <xiyou.wangcong@gmail.com>2018-08-19 12:22:06 -0700
committerDavid S. Miller <davem@davemloft.net>2018-08-21 12:45:44 -0700
commit97a3f84f2c84f81b859aedd2c186df09c2ee21a6 (patch)
tree94b69a5b9f938534b7ae0733cea74712c3f15472 /net/sched/act_sample.c
parentnet_sched: improve and refactor tcf_action_put_many() (diff)
net_sched: remove unnecessary ops->delete()
All ops->delete() wants is getting the tn->idrinfo, but we already have tc_action before calling ops->delete(), and tc_action has a pointer ->idrinfo. More importantly, each type of action does the same thing, that is, just calling tcf_idr_delete_index(). So it can be just removed. Fixes: b409074e6693 ("net: sched: add 'delete' function to action ops") Cc: Jiri Pirko <jiri@mellanox.com> Cc: Vlad Buslov <vladbu@mellanox.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
1 files changed, 0 insertions, 8 deletions
diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c
index 207b4132d1b0..44e9c00657bc 100644
--- a/net/sched/act_sample.c
+++ b/net/sched/act_sample.c
@@ -232,13 +232,6 @@ static int tcf_sample_search(struct net *net, struct tc_action **a, u32 index,
return tcf_idr_search(tn, a, index);
-static int tcf_sample_delete(struct net *net, u32 index)
- struct tc_action_net *tn = net_generic(net, sample_net_id);
- return tcf_idr_delete_index(tn, index);
static struct tc_action_ops act_sample_ops = {
.kind = "sample",
@@ -249,7 +242,6 @@ static struct tc_action_ops act_sample_ops = {
.cleanup = tcf_sample_cleanup,
.walk = tcf_sample_walker,
.lookup = tcf_sample_search,
- .delete = tcf_sample_delete,
.size = sizeof(struct tcf_sample),