path: root/net/sched/act_skbedit.c
diff options
authorVlad Buslov <vladbu@mellanox.com>2018-07-05 17:24:28 +0300
committerDavid S. Miller <davem@davemloft.net>2018-07-08 12:42:29 +0900
commitb409074e6693bcdaa7abbee2a035f22a9eabda53 (patch)
treef531c8c864cbffaa0c2258d2dada07b1fc03d33b /net/sched/act_skbedit.c
parentnet: sched: implement action API that deletes action by index (diff)
net: sched: add 'delete' function to action ops
Extend action ops with 'delete' function. Each action type to implements its own delete function that doesn't depend on rtnl lock. Implement delete function that is required to delete actions without holding rtnl lock. Use action API function that atomically deletes action only if it is still in action idr. This implementation prevents concurrent threads from deleting same action twice. Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Signed-off-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_skbedit.c')
1 files changed, 8 insertions, 0 deletions
diff --git a/net/sched/act_skbedit.c b/net/sched/act_skbedit.c
index c4ae4bd830aa..b3eaa120c7f4 100644
--- a/net/sched/act_skbedit.c
+++ b/net/sched/act_skbedit.c
@@ -267,6 +267,13 @@ static int tcf_skbedit_search(struct net *net, struct tc_action **a, u32 index,
return tcf_idr_search(tn, a, index);
+static int tcf_skbedit_delete(struct net *net, u32 index)
+ struct tc_action_net *tn = net_generic(net, skbedit_net_id);
+ return tcf_idr_delete_index(tn, index);
static struct tc_action_ops act_skbedit_ops = {
.kind = "skbedit",
@@ -276,6 +283,7 @@ static struct tc_action_ops act_skbedit_ops = {
.init = tcf_skbedit_init,
.walk = tcf_skbedit_walker,
.lookup = tcf_skbedit_search,
+ .delete = tcf_skbedit_delete,
.size = sizeof(struct tcf_skbedit),