aboutsummaryrefslogtreecommitdiffstats
path: root/net/sched/cls_bpf.c
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-11-02 20:04:12 +0000
committerDavid S. Miller <davem@davemloft.net>2017-11-03 15:52:38 +0900
commit53b3847be5cbdf819cf366ea9160369ff00dcf8e (patch)
treeaa87578f13e89d247e75d885d9ee47f1e7688848 /net/sched/cls_bpf.c
parenttcp: fix a lockdep issue in tcp_fastopen_reset_cipher() (diff)
downloadlinux-dev-53b3847be5cbdf819cf366ea9160369ff00dcf8e.tar.xz
linux-dev-53b3847be5cbdf819cf366ea9160369ff00dcf8e.zip
net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags
Currently gen_flags is being operated on by a logical && operator rather than a bitwise & operator. This looks incorrect as these should be bit flag operations. Fix this. Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator") Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload) Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_bpf.c')
-rw-r--r--net/sched/cls_bpf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c
index 5f701c8670a2..bc3edde1b9d7 100644
--- a/net/sched/cls_bpf.c
+++ b/net/sched/cls_bpf.c
@@ -174,7 +174,7 @@ static int cls_bpf_offload_cmd(struct tcf_proto *tp, struct cls_bpf_prog *prog,
}
}
- if (addorrep && skip_sw && !(prog->gen_flags && TCA_CLS_FLAGS_IN_HW))
+ if (addorrep && skip_sw && !(prog->gen_flags & TCA_CLS_FLAGS_IN_HW))
return -EINVAL;
return 0;