diff options
| author |   Vlad Buslov <vladbu@mellanox.com> | 2019-08-26 16:45:04 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-08-26 14:17:43 -0700 |
| commit | 5a6ff4b13d598573fc954f672cd2a267b76a01ec (patch) | |
| tree | 5d0222c2eb4a232f49a9b4f33dddd57ccf982586 /net/sched/cls_flower.c | |
| parent | net: sched: take rtnl lock in tc_setup_flow_action() (diff) | |
| download | linux-dev-5a6ff4b13d598573fc954f672cd2a267b76a01ec.tar.xz linux-dev-5a6ff4b13d598573fc954f672cd2a267b76a01ec.zip | |
net: sched: take reference to action dev before calling offloads
In order to remove dependency on rtnl lock when calling hardware offload
API, take reference to action mirred dev when initializing flow_action
structure in tc_setup_flow_action(). Implement function
tc_cleanup_flow_action(), use it to release the device after hardware
offload API is done using it.
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/sched/cls_flower.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index fb305bd45d93..2852fe6f50d2 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -465,6 +465,7 @@ static int fl_hw_replace_filter(struct tcf_proto *tp, err = tc_setup_cb_add(block, tp, TC_SETUP_CLSFLOWER, &cls_flower, skip_sw, &f->flags, &f->in_hw_count, true); + tc_cleanup_flow_action(&cls_flower.rule->action); kfree(cls_flower.rule); if (err) { @@ -1838,6 +1839,7 @@ static int fl_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb, TC_SETUP_CLSFLOWER, &cls_flower, cb_priv, &f->flags, &f->in_hw_count); + tc_cleanup_flow_action(&cls_flower.rule->action); kfree(cls_flower.rule); if (err) { |